Execution Dashboard Backend Pagination & Frontend Loading Icon #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunwp1
requested changes
Nov 23, 2024
There was a problem hiding this comment.
Looks good! I left a few comments. Please address them.
There are three issues that I found:
- Sorting by execution name doesn't work.
- The End Time column is too small to display the time in a single line. Probably reduce the status column size since it is unnecessarily big.
- Do we have a bigger button for sorting? It is too small to look at the colors.
For 2 and 3, since the issues are not related to this PR, you can create a new PR to fix these issues or fix them here.
core/gui/src/app/dashboard/component/admin/execution/admin-execution.component.ts
Outdated
Show resolved
Hide resolved
...scala/edu/uci/ics/texera/web/resource/dashboard/admin/execution/AdminExecutionResource.scala
Show resolved
Hide resolved
...scala/edu/uci/ics/texera/web/resource/dashboard/admin/execution/AdminExecutionResource.scala
Outdated
Show resolved
Hide resolved
core/gui/src/app/dashboard/component/admin/execution/admin-execution.component.ts
Outdated
Show resolved
Hide resolved
|
The sorting function on execution names should work. It seems not working might because of the default name for each execution is the same. The id in the parenthesis is not included in the execution name. |
… into Zhe-execution-optimization merge
kunwp1
approved these changes
Nov 25, 2024
...scala/edu/uci/ics/texera/web/resource/dashboard/admin/execution/AdminExecutionResource.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #3016 that execution dashboard takes long time to load.
Changed made:
Loading Icon:
Page Size Change:
