Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated scalapb definition #3182

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Conversation

Yicong-Huang
Copy link
Collaborator

The scalapb proto definition both present in workflow-core and amber. This PR removes the second copy.

@Yicong-Huang Yicong-Huang self-assigned this Dec 30, 2024
@Yicong-Huang Yicong-Huang added the refactoring Refactor the code label Dec 30, 2024
Base automatically changed from yicong-move-proto-under-core to master December 30, 2024 20:37
@Yicong-Huang Yicong-Huang merged commit 1d3561b into master Dec 31, 2024
8 checks passed
@Yicong-Huang Yicong-Huang deleted the yicong-remove-scalapb-dup branch December 31, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants