Replace JGraphT with scala-graph #3297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengquan-ni
added
dependencies
Xiao-zhen-Liu
requested changes
Mar 4, 2025
| import edu.uci.ics.amber.core.workflow.PhysicalLink | ||
| import org.jgrapht.alg.connectivity.BiconnectivityInspector | ||
| import edu.uci.ics.amber.core.workflow.{PhysicalLink, PhysicalPlan, WorkflowContext} | ||
| import edu.uci.ics.amber.engine.common.{AmberConfig, AmberLogging} | ||
| import org.jgrapht.graph.{DirectedAcyclicGraph, DirectedPseudograph} |
There was a problem hiding this comment.
jgrapht is still used in many other places in the amber module. Please do a thorough check.
| operatorList: List[LogicalOp], | ||
| links: List[LogicalLink] | ||
| ): DirectedAcyclicGraph[OperatorIdentity, LogicalLink] = { |
There was a problem hiding this comment.
Does the Graph class ensure the plan is a DAG? For jgrapht if a plan is not a DAG an error will be thrown. If Graph does not ensure the acyclicity part of a DAG, do we implement that ourselves? The acyclicity is crucial for scheduling (RegionDAG), which is currently still implemented as a jgrapht DAG.
| @transient private lazy val operatorMap: Map[PhysicalOpIdentity, PhysicalOp] = | ||
| operators.map(o => (o.id, o)).toMap | ||
|
|
||
| // the dag will be re-computed again once it reaches the coordinator. | ||
| @transient lazy val dag: DirectedAcyclicGraph[PhysicalOpIdentity, PhysicalLink] = { |
|
Since JgraphT is dual-licensed with EPL and EPL is ok-ish for the apache project, we decided to keep JGraphT.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of JGraphT with another library called scala-graph, which is under an apache2.0 license.
I evaluated the support for JGraphT use cases in scala-graph:
(Supported) create a DAG from both a logical and physical plan. This DAG should allow multiple edges between 2 vertices.
(Not supported) find bridges in a DAG. A bridge is an edge whose removal will cause an increase of weakly connected components.
compute maxChains, which requires
(Supported) find weakly connected components.
For the Not supported part, I re-implemented them.