eslint@9, remove resolutions and react-app #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading to the latest version of Yarn in multiple private dependencies and removing the ../packages link infrastructure, I started running into an error within the app that was complaining that eslint-plugin-jsx-a11y was being imported multiple times. Indeed, both eslint-config-airbnb and eslint-config-react-app both bring in this plugin. It's likely neater to stick to one of these or converge onto a single set of rules that we agree on. In either case, I need to remove one of them to get the app to build now, so this patch removes Airbnb's configs.
in case it's handy sometime
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Fork because of a required fix that hasn't been shipped yet.
|
Report too large to display inline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip. still need to bring back airbnb and replicate what kishan had set up back in texts desktop