-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: workspaces #1156
Draft
nikkothari22
wants to merge
89
commits into
develop
Choose a base branch
from
raven-orgs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: workspaces #1156
+5,052
−1,020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf: reduce re-renders in ChatBoxBody and memoize DateTooltip
nikkothari22
requested review from
janhvipatil,
prathameshkurunkar7 and
TITANiumRox
December 6, 2024 19:19
fix: do not fetch settings for non-admin users
fix: allow channels with same name in different workspaces but not in same workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workspaces allows users to create multiple "spaces" each having it's own channels.
Example use case: a company like Frappe wants to run internal comms, customer support/community engagement etc all with just one Raven account and site. They would create private workspaces for internal comms or 1-on-1 customer engagement, and public workspaces for community engagement. This could apply to any organisation trying to separate departments/teams or using Raven to communicate with external vendors/staff.
DMs are not included in workspaces and hence are "shared".
Things to do:
Permissions
A new role of "Raven Admin" has been created - users with this role can create workspaces.
Backend - APIs, Caching, Performance
Workspace-my-channel
instead of justmy-channel
is_dm_thread
to 1.Patches
is_dm_thread
in Raven Channel for all threads created inside DMs. Since DMs do not have any workspace, threads created in a DM do not need a workspace.is_dm_thread
in all existing threads created in a DMUI
Other unrelated fixes in this PR:
Closes #679