Skip to content
This repository has been archived by the owner on Nov 12, 2022. It is now read-only.

Wiremod 2022 Port #282

Open
wants to merge 61 commits into
base: master
Choose a base branch
from

Conversation

Bucovineanu
Copy link
Collaborator

About The Pull Request

MerchantGuild flavored port of all the newest changes to wiremod from tg. Working through it and looking at our version of the code, it's quite obvious we inherited quickly fluctuating code that is ever harder to work with, with features that are too much effort to reimplement even compared to me attempting to port these changes 3 or 4 times.

This port is drafted because it's missing important features and sprites we made, and I don't want to revert that work. There's things I've implemented in parallel with wiremod 2022, like adding components inside of the circuit menu or the computer vision component; some I'll keep the tg version of, some will be merged with our version, and I definitely do not intend to revert any unique functionality we have.

This port will remain a draft until I've judged it stable and with all of our rolled out features integrated into ti, and then it should be testmerged for final verifications.

Credit to SNIAPA for helping me with the port. Without him this wouldn't have happened.

Why It's Good For The Game

Being able to zoom in and out is good, familiarity is good, ease of pickpocketing code is good.

Changelog

🆑
expansion: Ported wiremod 2022
/:cl:

Bucovineanu and others added 30 commits June 11, 2022 14:42
Basically: delete old wiremod, bring in new wiremod folder. TGUI stuff not ported, anything outside of wiremod not ported.

# errors: 495
Adds a helper function to _lists.dm among other things, won't be the first or last time this happens
# errors: 266
Yeah I do wish I could be more descriptive, but it's just too much shit to add or move; admin and helpers mostly
Forgot to port it lol
@Bucovineanu Bucovineanu marked this pull request as ready for review June 15, 2022 21:41
Somehow this one slipped past the original mech shell PR!
Also changed mech shell icon to reuse the computer vision component sprite, fixes module duplicator icon
FUCKFUCKFUCK
@Bucovineanu Bucovineanu added the Mapping THIS IS GOING TO MERGE CONFLICT SOON label Jun 16, 2022
@github-actions github-actions bot added the Merge Conflict WE HATE MERGE CONFLICTS label Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Gooood shit HOLY FUCK Mapping THIS IS GOING TO MERGE CONFLICT SOON Merge Conflict WE HATE MERGE CONFLICTS TEST MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants