This repository has been archived by the owner on Nov 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Wiremod 2022 Port #282
Open
Bucovineanu
wants to merge
61
commits into
The-Merchants-Guild:master
Choose a base branch
from
mguildbiosciworkrepo:wiremodporting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wiremod 2022 Port #282
Bucovineanu
wants to merge
61
commits into
The-Merchants-Guild:master
from
mguildbiosciworkrepo:wiremodporting
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically: delete old wiremod, bring in new wiremod folder. TGUI stuff not ported, anything outside of wiremod not ported. # errors: 495
Adds a helper function to _lists.dm among other things, won't be the first or last time this happens # errors: 266
Yeah I do wish I could be more descriptive, but it's just too much shit to add or move; admin and helpers mostly
Forgot to port it lol
FUCKKKKKKKKK
Also breaks my rule by changing something technically out of the scope of this PR, but like, it's not a gameplay change, it's a better fuckign previewer for dmi's, so I'm letting myself slip with this one.
Somehow this one slipped past the original mech shell PR!
Also changed mech shell icon to reuse the computer vision component sprite, fixes module duplicator icon
It's its own PR now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Feature
Gooood shit
HOLY FUCK
Mapping
THIS IS GOING TO MERGE CONFLICT SOON
Merge Conflict
WE HATE MERGE CONFLICTS
TEST MERGE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
MerchantGuild flavored port of all the newest changes to wiremod from tg. Working through it and looking at our version of the code, it's quite obvious we inherited quickly fluctuating code that is ever harder to work with, with features that are too much effort to reimplement even compared to me attempting to port these changes 3 or 4 times.
This port is drafted because it's missing important features and sprites we made, and I don't want to revert that work. There's things I've implemented in parallel with wiremod 2022, like adding components inside of the circuit menu or the computer vision component; some I'll keep the tg version of, some will be merged with our version, and I definitely do not intend to revert any unique functionality we have.
This port will remain a draft until I've judged it stable and with all of our rolled out features integrated into ti, and then it should be testmerged for final verifications.
Credit to SNIAPA for helping me with the port. Without him this wouldn't have happened.
Why It's Good For The Game
Being able to zoom in and out is good, familiarity is good, ease of pickpocketing code is good.
Changelog
🆑
expansion: Ported wiremod 2022
/:cl: