drt: Better Dynamic Programming (DP) Nodes and Elimination of getNestedIdx #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
…nction Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Is |
No it is a vector of vectors indeed. Actually, the current implementation represents a matrix (with a lot of empty data). This is what I want to talk about on today's meeting actually, but I gave myself a headstart and already started changing things |
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is branched from #5872 and is waiting for it to merge.
std::vector<FlexDPNode>& nodesis a convoluted data structure, it has a non intuitive way of indexing nodes and holds a lot of empty data. This is the first PR in a sequences that will refactor this structure to bestd::vector<std::vector<FlexDPNode>>& nodes, which is a more intuitive data structure for it and will make the code more readable.Here are the changes and how they contribute to this objective:
FlexDPNode Decoupling from old nodes structure
The
FlexDPNodeobject holds a the privateprev_node_idx_which is the index of the previous node in the nodes structure. This was changed so now it holds a pointer to the node itself, if one exists.Other changes were made to the object adding auxiliary methods to make the code more readable, here are some examples:
(curr_node->hasPrevNode())reads better than(curr_node->getPrevNodeIdx() != -1)(prev_node->isSource() || curr_node->isDrain())reads better thanif (prev_idx_1 == -1 || curr_idx_1 == (int) insts.size())The use of
idx_as astd::pair<int,int>allows for getting both values without the use ofgetNestedIdx()which leads to the second changeElimination of getNestedIdx()
As code was refactored, getting the composed idx directly from node was more convenient and direct than using
getNestedIdx(), so it was completely eliminated to only get idx from nodes.This required both
getEdgeCost()functions to getFlexDPNode*as inputs, instead of node indexes.