odb: In dbITerm::getGeometries, return layer + rect

[smunaut]

Currently only the rect is returned but that's not very useful. So instead we return pairs of layer + rect.

The appropriate SWIG mapping is also added so the result is usable both in Python and in TCL.

Note that someone should definitely have a close look at the SWIG mapping because I have very little experience with those.
I did test that it seems to work as expected in both TCL and Python though.

[gadfort]

Could this return a set of dbShape instead? https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/src/odb/include/odb/dbShape.h

[maliberty]

Looking your suggestion I noticed dbITermShapeItr which might be what is wanted here.

[github-actions]

clang-tidy made some suggestions

[maliberty]

@smunaut this has compilation and clang-tidy errors? Do you plan to fix this up?

[smunaut]

clang-tidy was just a suggested, I've applied it.

The compilation errors ... they're just warning turned to errors but
(1) I don't have those locally
(2) I have no clue whatsoever what is wrong and what the compiler wants for me. As far as I can tell I'm doing the EXACT same thing as the swig binding just above for another type and this one doesn't trigger it ... so I'd need a C++ or SWIG expert to look at it, because I don't understand what it thinks is wrong.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[smunaut]

Ok, I think I fixed it actually. For some reason it says pr-hread failed but if you click on it, all build succeeded. I think it got a bit confused because I pushed a new version before the previous build was done ?

[maliberty]

You need to merge master to resolve the c++20 compiler issue.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[smunaut]

Rebased to master, all checks passed.