Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read mitigator info from Azure #185

Merged
merged 9 commits into from
Feb 27, 2025
Merged

Read mitigator info from Azure #185

merged 9 commits into from
Feb 27, 2025

Conversation

matt-dray
Copy link
Contributor

@matt-dray matt-dray commented Feb 26, 2025

Close #182.

  • Prefer to read mitigator-lookup.csv from Azure, which already uses the new naming convention for frailty mitigators.
  • Add an .Renviron.example to note the keys required in .Renviron.
  • Add a note for developers about needing an .Renviron into the README.
  • Update renv.lock because {AzureStor} is now needed (also seemed to clean out some unused packages too).

@matt-dray matt-dray added update Improvements or additions to existing info must labels Feb 26, 2025
@matt-dray matt-dray self-assigned this Feb 26, 2025
@matt-dray

This comment was marked as resolved.

Copy link
Member

@ChrisBeeley ChrisBeeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test but otherwise LGTM

@matt-dray
Copy link
Contributor Author

Update: @yiwen-h checked and it's likely to be an authentication issue. I think I just need an ifelse in the get_container() function. Will amend and re-commit.

@matt-dray
Copy link
Contributor Author

Thank you for joining me on this saga, @yiwen-h. Ready for review (at last). 🥲

@matt-dray matt-dray merged commit 7ac9b21 into main Feb 27, 2025
1 check passed
@matt-dray matt-dray deleted the 182-frailty-azure branch February 27, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must update Improvements or additions to existing info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change name of frailty mitigators on mitigators lookup
3 participants