-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add ci.yml
#18
Conversation
37b5986
to
5b588aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vil02
Great work! However there is a conflict in the modules.
@SatinWukerORIG: Is there anything left to be done with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! And sorry that I didn't see your "request review" on time!
Fixes #13.
It works on my end, cf. vil02#1, vil02#2 (please have a look to the action runs).
The
CMakeLists.txt
is not perfect, but I think it is good enough for now:modules
,tests
andexample
directories for*.f90
files,tests/sorts
andtests/some_other_algorithms
this would not cause any problem.When this will be merged, there are few things on the to do list:
make of all of the files in theother
directory proper modules and add tests for them,-Werror
flag (done in style: treat warnings as errors #26),