Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ci.yml #18

Merged
merged 6 commits into from
Sep 24, 2024
Merged

chore: add ci.yml #18

merged 6 commits into from
Sep 24, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 16, 2024

Fixes #13.

It works on my end, cf. vil02#1, vil02#2 (please have a look to the action runs).

The CMakeLists.txt is not perfect, but I think it is good enough for now:

  • scans the modules, tests and example directories for *.f90 files,
  • all of the tests and examples are linked with all of the modules,
  • the tests and the examples, have pretty unique name: even if there would be two files with the same name in tests/sorts and tests/some_other_algorithms this would not cause any problem.

When this will be merged, there are few things on the to do list:

@vil02 vil02 force-pushed the add_ci branch 3 times, most recently from 37b5986 to 5b588aa Compare September 16, 2024 19:53
@vil02 vil02 marked this pull request as ready for review September 16, 2024 20:04
Copy link
Member

@SatinWukerORIG SatinWukerORIG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vil02
Great work! However there is a conflict in the modules.

@vil02
Copy link
Member Author

vil02 commented Sep 24, 2024

@SatinWukerORIG: Is there anything left to be done with this PR?

Copy link
Member

@SatinWukerORIG SatinWukerORIG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! And sorry that I didn't see your "request review" on time!

@SatinWukerORIG SatinWukerORIG merged commit f9888a4 into TheAlgorithms:main Sep 24, 2024
@vil02 vil02 deleted the add_ci branch September 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI
2 participants