Added three algorithms for calculating nth Fibbonacci number #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can I merge it? |
andreicioban
requested changes
Nov 13, 2018
There was a problem hiding this comment.
Just merged a PR which added the Mathematics package.
There is already a Fibbonacci.scala implementation using Streams.
Would you mind moving this into that package(it makes more sense) and rename one of the implementations, since your implementation is as valuable as the other one because has a different approach.
|
@olexandryermilov i know you did the PR before the one i'm talking above, but i got them in reverse order. Sorry about that. |
|
Ok, I will look at it and restructure it during the next few days. |
|
Status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.