Root state and simple menu with credits #16
Conversation
|
I'm fine with merging it and then iterating on that. Code looks tidy :) |
|
More changes than I originally planned, requesting re-review |
|
|
||
| use bevy::{color::palettes::tailwind, prelude::*}; | ||
|
|
||
| pub use widgets::*; |
There was a problem hiding this comment.
IMO it would be better to pub mod widgets instead. But that's just my opinion, and can be discussed after this PR is merged.
| Credits, | ||
| } | ||
|
|
||
| fn setup(mut commands: Commands) { |
There was a problem hiding this comment.
Non-specific system names like "set up" and "update" are confusing, and encourage putting everything in one system instead of splitting into multiple systems. Fine to keep it this way for this PR, though.
There was a problem hiding this comment.
Yes, but overly specific names without context would be weird too. Adding some actual game logic would show both sides
There was a problem hiding this comment.
I added a comment for game logic, hope we can iterate on this further though
Add `dev` and `dev_native` features
Co-authored-by: Jan Hohenheim <[email protected]>
Co-authored-by: Ben Frankel <[email protected]>
|
@benfrankel merging this since I think your concerns have been addressed and you mentioned that you are fine with resolving some nitpicks with follow-up PRs. Hope you're alright with that :) |
Fixes #3, #9
Partially: #4
Based on https://github.com/MiniaczQ/bevy-substate-based-ui
This is very experimental, feel free to propose large changes to the structure