Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed check wasManuallyRemoved method deprecated #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xnohat
Copy link

@xnohat xnohat commented Aug 28, 2020

Please be sure you are submitting this against the master branch.

//: # This Pull Request (Place an 'X' for each):

Risk Level No Low High
Alters Lead Data? X
Schema Change? X
Adds A Query or Modifies Existing Query? X
Adds or Modifies Existing Auto-Enhancer? X
Modifies Ingestion Process? X
Modifies sendContact Data? X

Description:

Copy link

@nickveenhof nickveenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixed an issue we had in Mautic 3.3.3

@@ -97,7 +97,8 @@ public function addLeadToCompany($companies, $lead)

if (null != $companyLead) {
// @deprecated support to be removed in 3.0
if ($companyLead->wasManuallyRemoved()) {
//if ($companyLead->wasManuallyRemoved()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this comment, doesn't really matter much

nickveenhof added a commit to nickveenhof/mautic-extended-field that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants