Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add affine transformations of the Shape model #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yu-AnChen
Copy link

Description

Support AffineTransform model in Shape's transform property. This feature was introduced in OMERO 5.3, details can be found in this OME blog post.

I utilize the transform property to transfer ROIs between images of the same sample, which were captured using different microscopes or magnifications.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.

@Yu-AnChen
Copy link
Author

Thanks for making ezomero, it's super helpful! Please advise this PR and feel free to make any changes :)

@erickmartins
Copy link
Collaborator

Thanks for the PR! I'll try to have a closer look at it next week.

@erickmartins
Copy link
Collaborator

a few notes:

  1. in rois.py, the transform field should be in each individual ROI type - not on the ezShape dataclass. I think tests are currently failing because of that;
  2. please add a test case using the new transform field for each shape in tests/test_rois.py;
  3. please add transforms into the shapes created in roi_fixture at tests/conftest.py.

Once more, thanks for the contribution!

@Yu-AnChen
Copy link
Author

Thank you! I'll work on it soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants