use JWT timestamp to validate claims #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows better testability. This feature is better described in the `JWT` class : > Allow the current timestamp to be specified. Useful for fixing a value within unit testing. > https://github.com/firebase/php-jwt/blob/3b454f90f147db65a615041dec6661f427d6cb00/src/JWT.php#L43-L50
|
Didn't notice at first but #178 is related. I could implement the |
|
Yes make sens 👍 |
…tion This allows time manipulation for testing purpose. > as seen in TheNetworg#178, see https://github.com/firebase/php-jwt/blob/3b454f90f147db65a615041dec6661f427d6cb00/tests/JWTTest.php#L79-L90 for a usecase in testing
|
Added This allows time manipulation for testing purpose. |
|
Ping @hajekj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows better testability.
This feature is better described in the
JWTclass :