Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Validation with JavaScript lesson: Update text with a lesson link #29300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhilash15500
Copy link
Contributor

@abhilash15500 abhilash15500 commented Jan 9, 2025

Because

I just noticed that we have a link for Revisiting Rock Paper Scissors in that paragraph but not for library project so it would be easier to navigate thats it.

This PR

  • I changed the library text to a link

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Update the library text with a lesson link  for better accesibility. It would help the users to jump to the project link quickly just like how its done with rps link below in the paragraph.
@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Jan 9, 2025
@abhilash15500 abhilash15500 changed the title Update the library text with a lesson link Form Validation with JavaScript lesson: Update text with a lesson link Jan 9, 2025
@JoshDevHub
Copy link
Contributor

Thank you for making this PR @abhilash15500

Unfortunately it's kind of tricky to backlink to a project in the JS course. This is because the course is in the Node/Express path and in the Ruby on Rails path, but the paths have separate project pages because we want to keep the submissions separate.

So a person reading this lesson while working through the Ruby on Rails path will get your link: https://www.theodinproject.com/lessons/node-path-javascript-library

But that isn't the link to the project they did. This is the link to the project page for people doing the Ruby course: https://www.theodinproject.com/lessons/javascript-library

This isn't a problem in the Foundations course, where everyone is doing all the same lessons and projects in the same order, which is why the Rock Paper Scissors link works fine.

I'll talk to others on the maintainer team and get some other opinions on what to do for this.

@abhilash15500
Copy link
Contributor Author

Yes that totally makes sense. 😊

@abhilash15500 abhilash15500 reopened this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants