feat(napi): update CI

TheOpenDictionary · Nov 23, 2024 · 0eec345 · 0eec345
1 parent bcebc36
commit 0eec345
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/napi.yml b/.github/workflows/napi.yml
@@ -259,7 +259,7 @@ jobs:
         run: ls -R .
         shell: bash
       - name: Test bindings
-        run: docker run --rm -v $(pwd):/build -w /build node:${{ matrix.node }}-slim pnpm --filter="@odict/node" test
+        run: docker run --rm -v $(pwd):/build -w /build node:${{ matrix.node }}-slim sh -c "npm install -g pnpm && pnpm --filter=\"@odict/node\" test"
   test-linux-x64-musl-binding:
     name: Test bindings on x86_64-unknown-linux-musl - node@${{ matrix.node }}
     needs:
@@ -293,7 +293,7 @@ jobs:
         run: ls -R .
         shell: bash
       - name: Test bindings
-        run: docker run --rm -v $(pwd):/build -w /build node:${{ matrix.node }}-alpine pnpm --filter="@odict/node" test
+        run: docker run --rm -v $(pwd):/build -w /build node:${{ matrix.node }}-alpine sh -c "npm install -g pnpm && pnpm --filter=\"@odict/node\" test"
   test-linux-aarch64-gnu-binding:
     name: Test bindings on aarch64-unknown-linux-gnu - node@${{ matrix.node }}
     needs:

diff --git a/bindings/node/tests/dictionary.spec.ts b/bindings/node/tests/dictionary.spec.ts
@@ -41,8 +41,9 @@ describe("Dictionary", () => {
   });
 
   it("returns the path correctly", () => {
-    expect(dict1.path).toBe(dict1Path.replace(".xml", ".odict"));
-    expect(dict2.path).toBe(dict2Path.replace(".xml", ".odict"));
+    // Needs toContain instead of toBe seeing Windows paths start with \\?\
+    expect(dict1.path).toContain(dict1Path.replace(".xml", ".odict"));
+    expect(dict2.path).toContain(dict2Path.replace(".xml", ".odict"));
   });
 
   describe("lookup", () => {
@@ -100,8 +101,8 @@ describe("Dictionary", () => {
       const dict = new Dictionary("fake-alias");
       await dict.lookup("dog");
     } catch (e) {
-      expect((e as Error).message).toEqual(
-        "No such file or directory (os error 2)"
+      expect((e as Error).message).toContain(
+        "(os error 2)"
       );
     }
   });