Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustscan #27

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Rustscan #27

wants to merge 7 commits into from

Conversation

lap1nou
Copy link
Contributor

@lap1nou lap1nou commented Apr 30, 2024

Greetings,

This PR aims to add rustscan in resources so one can drop the binary on target machine.

I personally find it useful to have a port scanner available that one can drop on a target.

Regards.

Copy link
Member

@Dramelac Dramelac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
Every release dont always have the asset mentionned here unfortunately.
It was [...]-windows.zip but the latest release use [...]-windows.tar.xz. Can you update this before merging ? Thanks !

@lap1nou
Copy link
Contributor Author

lap1nou commented Jan 24, 2025

Hey @Dramelac,

Sorry for the late answer, which tag are you talking about ? I see the file rustscan-$VERSION-x86_64-windows.zip for each latest release.

image

@Dramelac
Copy link
Member

It was 2.2.3 release back then. I see now there is both format indeed. Maybe we could add a fallback to the other fileformat in case the first one is missing in a futur release.

@lap1nou
Copy link
Contributor Author

lap1nou commented Jan 24, 2025

This should do the trick I think.

@ShutdownRepo
Copy link
Member

@lap1nou theres still one comment to check (the chkfs command), but apart from that we should be good to go
Can you take a look at the comment pending?

@lap1nou lap1nou requested a review from Dramelac February 22, 2025 13:49
@lap1nou
Copy link
Contributor Author

lap1nou commented Feb 22, 2025

@ShutdownRepo Hey sure no problem, but I must be blind because I can't see the comment you are mentioning

EDIT: Oh I think I got it, chkfs actually check for directory not file, gonna fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants