Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Job Sequencing in C# #4005

Merged
merged 21 commits into from
Nov 10, 2024
Merged

Conversation

alstondsouza1
Copy link
Contributor

@alstondsouza1 alstondsouza1 commented Nov 10, 2024

I Am Adding a New Code Snippet in an Existing Language

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Job Sequencing code looks fine, but the Remove All Whitespace code needs to be removed. Sorry about that. When I assigned you to that sample, I did not check if there was already one. We typically do not accept modifications to existing samples unless there is a bug and a really good reason why the sample needs to be changed. Please see this section of the Contributing Guide for details.

@rzuckerm rzuckerm added enhancement Any code that improves the repo job sequencing See: https://sampleprograms.io/projects/job-sequencing/ labels Nov 10, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@alstondsouza1
Copy link
Contributor Author

@rzuckerm Thank you for the clarification! I have already removed the Remove All Whitespace code as requested.

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @alstondsouza1

@rzuckerm rzuckerm merged commit 1940e66 into TheRenegadeCoder:main Nov 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo job sequencing See: https://sampleprograms.io/projects/job-sequencing/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants