-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Collection.values, fix editField and file return types, fix bad fields showing up in some searches #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRolfFR
requested changes
Feb 17, 2024
3vorp
changed the title
Add Collection.values, fix editField return types
Add Collection.values, fix editField and file return types, fix bad fields showing up in some searches
Feb 18, 2024
TheRolfFR
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather implement values on the server side
…spec also updated dependencies
basically instead of always wrapping the return value in another promise constructor, we just return the promise from the axios request
TheRolfFR
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection.values
:Getting every existing value in a collection without duplicates is a really common operation that doesn't currently exist in Firestorm at all, so I added a fully tested and typed
Collection.values
method. It's a slightly simpler version of the SQLSELECT DISTINCT
statement, but it also supports directly merging array fields using theflatten
option (useful for texture tags, user roles, etc).Type fixes:
Collection.editField
andCollection.editFieldBulk
now return confirmations like the other write methods (although different to theWriteConfirmation
type used by all other write methods?)files.upload
andfiles.delete
extract the Axios request and returnWriteConfirmation
s like all other methods.Collection.select
now picks the correct return parameters directly instead of returning a partial object (this was actually painful).NoMethods<T>
type with a more generalizedRemoveMethods<T>
type.Writable<T>
with more specificSettable<T>
andAddable<T>
types for set and add operations respectively.Other changes:
{@link }
properties.