Merge branch 'v3.33' into merge/v3.32.3

TheThingsNetwork · Dec 17, 2024 · 64b853a · 64b853a
2 parents 2824f2a + a1e2469
commit 64b853a
Show file tree

Hide file tree

Showing 261 changed files with 21,407 additions and 6,288 deletions.
diff --git a/.github/workflows/changelog-cutoff.yml b/.github/workflows/changelog-cutoff.yml
@@ -14,7 +14,7 @@ env:
 jobs:
   cutoff_changelog:
     name: Cutoff changelog
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 30
     steps:
       - name: Check branch

diff --git a/.github/workflows/console-e2e.yml b/.github/workflows/console-e2e.yml
@@ -29,7 +29,7 @@ env:
 jobs:
   determine-if-required:
     name: Determine if run is required
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     outputs:
       needs-to-run: ${{ steps.check-result.outputs.passed != 'true' }}
       hash: ${{ steps.get-hash.outputs.hash }}
@@ -57,7 +57,7 @@ jobs:
         run: test -f .cache/passed && echo "passed=$(cat .cache/passed)" >> $GITHUB_OUTPUT
   preparation:
     name: Run preparations
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     needs: determine-if-required
     if: needs.determine-if-required.outputs.needs-to-run == 'true'
     timeout-minutes: 30
@@ -113,7 +113,7 @@ jobs:
           path: build.zip
   end-to-end:
     name: Main frontend end-to-end tests (Chrome)
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     env:
       NODE_ENV: development
       CYPRESS_MACHINE_NUMBER: ${{ matrix.machines }}
@@ -213,8 +213,8 @@ jobs:
           name: cypress-failed-test-spec
           path: .cache/.failed-specs-*.txt
   cross-browser-smoke:
-    name: Cross-browser smoke tests (Firefox 115.7.0 ESR)
-    runs-on: ubuntu-22.04
+    name: Cross-browser smoke tests (Firefox 129.0)
+    runs-on: ubuntu-24.04
     env:
       NODE_ENV: development
     needs: [determine-if-required, preparation]
@@ -240,7 +240,7 @@ jobs:
         run: unzip -o build.zip
       - name: Install FF 115.7.0 ESR
         run: |
-          wget --no-verbose -O /tmp/firefox.tar.bz2 https://download-installer.cdn.mozilla.net/pub/firefox/releases/115.7.0esr/linux-x86_64/en-US/firefox-115.7.0esr.tar.bz2
+          wget --no-verbose -O /tmp/firefox.tar.bz2 https://download-installer.cdn.mozilla.net/pub/firefox/releases/129.0/linux-x86_64/en-US/firefox-129.0.tar.bz2
           tar -C /opt -xjf /tmp/firefox.tar.bz2
           rm /tmp/firefox.tar.bz2
           sudo ln -fs /opt/firefox/firefox /usr/bin/firefox
@@ -272,7 +272,7 @@ jobs:
           path: cypress/screenshots
   cache-result:
     name: Write result cache
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     needs: [preparation, end-to-end, cross-browser-smoke, determine-if-required]
     timeout-minutes: 5
     steps:

diff --git a/.github/workflows/create-release-branch.yml b/.github/workflows/create-release-branch.yml
@@ -17,7 +17,7 @@ env:
 jobs:
   create_release:
     name: Create release branch
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 30
     steps:
       - name: Check branch

diff --git a/.github/workflows/general.yml b/.github/workflows/general.yml
@@ -5,7 +5,7 @@ on: pull_request
 jobs:
   quality:
     name: Code Quality
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 5
     steps:
       - name: Check out code

diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -3,22 +3,22 @@ name: Go Code
 on:
   pull_request:
     paths:
-      - ".github/workflows/go.yml"
-      - "*.go"
-      - ".revive.toml"
-      - "cmd/**"
-      - "go.mod"
-      - "go.sum"
-      - "Makefile"
-      - "pkg/**"
-      - "!pkg/webui/**"
-      - "pkg/webui/**.go"
-      - "tools/**"
+      - '.github/workflows/go.yml'
+      - '*.go'
+      - '.revive.toml'
+      - 'cmd/**'
+      - 'go.mod'
+      - 'go.sum'
+      - 'Makefile'
+      - 'pkg/**'
+      - '!pkg/webui/**'
+      - 'pkg/webui/**.go'
+      - 'tools/**'
 
 jobs:
   quality:
     name: Code Quality
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 15
     steps:
       - name: Check out code
@@ -42,29 +42,29 @@ jobs:
       - name: Lint code
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.57.2
+          version: v1.62.2
           only-new-issues: true
           args: --timeout=10m ./pkg/... ./cmd/...
 
   test:
     name: Tests
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     permissions:
       contents: read
       id-token: write
     services:
       postgres:
         image: postgres
         ports:
-          - "5432/tcp"
+          - '5432/tcp'
         env:
           POSTGRES_USER: root
           POSTGRES_PASSWORD: root
         options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
       redis:
         image: redis:7
         ports:
-          - "6379/tcp"
+          - '6379/tcp'
     timeout-minutes: 15
     steps:
       - name: Create ttn_lorawan_is_test DB
@@ -85,11 +85,11 @@ jobs:
         if: "${{ env.AWS_REGION != '' }}"
         uses: aws-actions/configure-aws-credentials@v4
         with:
-          aws-region: "${{ secrets.AWS_REGION }}"
-          role-to-assume: "arn:aws:iam::${{ secrets.AWS_USER_ID }}:role/${{ secrets.AWS_ROLE_NAME }}"
-          role-session-name: "${{ secrets.AWS_ROLE_NAME }}-${{ github.job }}-${{ github.run_id }}"
+          aws-region: '${{ secrets.AWS_REGION }}'
+          role-to-assume: 'arn:aws:iam::${{ secrets.AWS_USER_ID }}:role/${{ secrets.AWS_ROLE_NAME }}'
+          role-session-name: '${{ secrets.AWS_ROLE_NAME }}-${{ github.job }}-${{ github.run_id }}'
         env:
-          AWS_REGION: "${{ secrets.AWS_REGION }}"
+          AWS_REGION: '${{ secrets.AWS_REGION }}'
       - name: Check out code
         uses: actions/checkout@v4
       - name: Install Go and Dependencies
@@ -101,10 +101,10 @@ jobs:
       - name: Test code
         env:
           SQL_DB_ADDRESS: localhost:${{ job.services.postgres.ports['5432'] }}
-          SQL_DB_AUTH: "root:root"
+          SQL_DB_AUTH: 'root:root'
           REDIS_ADDRESS: localhost:${{ job.services.redis.ports['6379'] }}
-          TEST_REDIS: "1"
-          TEST_SLOWDOWN: "8"
+          TEST_REDIS: '1'
+          TEST_SLOWDOWN: '8'
           GCP_CREDENTIALS: ${{ secrets.GCP_TEST_CREDENTIALS }}
           TEST_BUCKET: ttn-lorawan-test
         run: tools/bin/mage go:test

diff --git a/.github/workflows/issue-triage.yml b/.github/workflows/issue-triage.yml
@@ -6,7 +6,7 @@ on:
 jobs:
   triage:
     name: Triage New Issues
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 5
     steps:
       - name: Add "needs/triage" label

diff --git a/.github/workflows/js.yml b/.github/workflows/js.yml
@@ -18,7 +18,7 @@ on:
 jobs:
   quality:
     name: Code Quality
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 15
     steps:
       - name: Check out code
@@ -46,7 +46,7 @@ jobs:
 
   test:
     name: Tests
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 15
     steps:
       - name: Check out code

diff --git a/.github/workflows/mergeability.yml b/.github/workflows/mergeability.yml
@@ -11,7 +11,7 @@ jobs:
   check_mergeability:
     name: Check Mergeability
     if: ${{ github.repository == 'TheThingsNetwork/lorawan-stack' }}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     env:
       MERGE_CONFLICTS_IGNORE: |
         CHANGELOG.md

diff --git a/.github/workflows/pr-labels.yml b/.github/workflows/pr-labels.yml
@@ -3,7 +3,7 @@ on: pull_request
 
 jobs:
   triage:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 5
     steps:
       - uses: actions/labeler@v5

diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml
@@ -10,7 +10,7 @@ on:
 jobs:
   protos:
     name: Generate protos
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 5
     steps:
       - name: Check out code

diff --git a/.github/workflows/release-rc.yml b/.github/workflows/release-rc.yml
@@ -13,7 +13,7 @@ env:
 jobs:
   release:
     name: Release-candidate release
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 30
     steps:
       - name: Check branch

diff --git a/.github/workflows/release-snapshot.yml b/.github/workflows/release-snapshot.yml
@@ -12,7 +12,7 @@ env:
 jobs:
   release:
     name: Snapshot release
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 30
     steps:
       - name: Check out code

diff --git a/.github/workflows/release-tag.yml b/.github/workflows/release-tag.yml
@@ -8,7 +8,7 @@ env:
 jobs:
   release:
     name: Tag release
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     permissions:
       contents: write
       id-token: write

diff --git a/.golangci.yml b/.golangci.yml
@@ -17,8 +17,8 @@ linters:
     # Enabled manually:
     - asciicheck # Finds non-ASCII identifiers.
     - bodyclose # Finds HTTP response bodies that are not closed.
+    - copyloopvar # Finds for loop variables that are overwritten.
     - errorlint # Finds problems with error wrapping.
-    - exportloopref # Finds pointers to range variables.
     - goconst # Finds repeated strings that could be replaced by a const.
     - gocyclo # Finds funcs with high cyclomatic complexity.
     - godot # Finds comments that do not end with a period.

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,8 +19,30 @@ For details about compatibility between different releases, see the **Commitment
 
 ### Fixed
 
+- Enforce default page limit on AS and NS List RPCs if a value is not provided in the request.
+- Swapped field order in `RelayNotifyNewEndDeviceReq` MAC command.
+
 ### Security
 
+## [3.33.0] - unreleased
+
+### Added
+
+- Support user email notification preferences.
+  - This requires an Identity Server database migration (`ttn-lw-stack is-db migrate`).
+- Support for managing MAC settings profiles.
+  - This feature is experimental and subject to change.
+- Support pausing webhook in the edit webhook view in console
+- Add more specific rights for user operations.
+  - The rights added were for listing and creating rights.
+  - Admin validation associated with these operations remains.
+- Add purge rights for application, organizations, Oauth clients, gateways and user operations.
+
+### Fixed
+
+- Fix OAuth client authorizations delete request in the Console.
+- Consecutive disconnect/reconnect messages in the Live Data view in the Console.
+
 ## [3.32.3] - 2024-12-04
 
 ## [3.32.2] - 2024-11-18
@@ -2898,7 +2920,8 @@ For details about compatibility between different releases, see the **Commitment
 NOTE: These links should respect backports. See https://github.com/TheThingsNetwork/lorawan-stack/pull/1444/files#r333379706.
 -->
 
-[unreleased]: https://github.com/TheThingsNetwork/lorawan-stack/compare/v3.32.3...v3.32
+[unreleased]: https://github.com/TheThingsNetwork/lorawan-stack/compare/v3.33.0...v3.33
+[3.33.0]: https://github.com/TheThingsNetwork/lorawan-stack/compare/v3.32.2...v3.33.0
 [3.32.3]: https://github.com/TheThingsNetwork/lorawan-stack/compare/v3.32.2...v3.32.3
 [3.32.2]: https://github.com/TheThingsNetwork/lorawan-stack/compare/v3.32.1...v3.32.2
 [3.32.1]: https://github.com/TheThingsNetwork/lorawan-stack/compare/v3.32.0...v3.32.1

diff --git a/Dockerfile b/Dockerfile
@@ -12,7 +12,7 @@ RUN rm -rf /srv/ttn-lorawan/lorawan-frequency-plans/.git
 COPY data/lorawan-webhook-templates /srv/ttn-lorawan/lorawan-webhook-templates
 RUN rm -rf /srv/ttn-lorawan/lorawan-webhook-templates/.git
 
-FROM alpine:3.19
+FROM alpine:3.21
 
 RUN addgroup -g 886 thethings && adduser -u 886 -S -G thethings thethings
 

diff --git a/api/buf.yaml b/api/buf.yaml
@@ -31,6 +31,7 @@ lint:
       - ttn/lorawan/v3/messages.proto
       - ttn/lorawan/v3/metadata.proto
       - ttn/lorawan/v3/rights.proto
+      - ttn/lorawan/v3/notification_service.proto
     ENUM_VALUE_UPPER_SNAKE_CASE:
       - ttn/lorawan/v3/rights.proto
     ENUM_ZERO_VALUE_SUFFIX:
@@ -100,6 +101,7 @@ lint:
       - ttn/lorawan/v3/identityserver.proto
       - ttn/lorawan/v3/joinserver.proto
       - ttn/lorawan/v3/networkserver.proto
+      - ttn/lorawan/v3/networkserver_mac_settings_profile.proto
       - ttn/lorawan/v3/notification_service.proto
       - ttn/lorawan/v3/oauth_services.proto
       - ttn/lorawan/v3/organization_services.proto
@@ -126,6 +128,7 @@ lint:
       - ttn/lorawan/v3/identityserver.proto
       - ttn/lorawan/v3/joinserver.proto
       - ttn/lorawan/v3/networkserver.proto
+      - ttn/lorawan/v3/networkserver_mac_settings_profile.proto
       - ttn/lorawan/v3/notification_service.proto
       - ttn/lorawan/v3/oauth_services.proto
       - ttn/lorawan/v3/organization_services.proto
@@ -153,6 +156,7 @@ lint:
       - ttn/lorawan/v3/identityserver.proto
       - ttn/lorawan/v3/joinserver.proto
       - ttn/lorawan/v3/networkserver.proto
+      - ttn/lorawan/v3/networkserver_mac_settings_profile.proto
       - ttn/lorawan/v3/oauth_services.proto
       - ttn/lorawan/v3/organization_services.proto
       - ttn/lorawan/v3/packetbrokeragent.proto