ns: Convert LastBatteryPercentage value to [0, 100] interval

TheThingsNetwork · Jan 22, 2025 · d63d032 · d63d032
1 parent ad82414
commit d63d032
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/api/ttn/lorawan/v3/api.md b/api/ttn/lorawan/v3/api.md
@@ -8954,7 +8954,7 @@ ncrc: [scheduled.advanced]
 
 | Field | Validations |
 | ----- | ----------- |
-| `value` | <p>`float.lte`: `1`</p><p>`float.gte`: `0`</p> |
+| `value` | <p>`float.lte`: `100`</p><p>`float.gte`: `0`</p> |
 
 ### <a name="ttn.lorawan.v3.MessagePayloadFormatters">Message `MessagePayloadFormatters`</a>
 

diff --git a/api/ttn/lorawan/v3/messages.proto b/api/ttn/lorawan/v3/messages.proto
@@ -193,7 +193,7 @@ message LastBatteryPercentage {
   // The value is defined in the [0, 100] interval.
   google.protobuf.FloatValue value = 2 [(validate.rules).float = {
     gte: 0,
-    lte: 1
+    lte: 100
   }];
   // Time when last DevStatus MAC command was received.
   google.protobuf.Timestamp received_at = 3;

diff --git a/pkg/networkserver/grpc_gsns.go b/pkg/networkserver/grpc_gsns.go
@@ -43,6 +43,7 @@ import (
 	"google.golang.org/protobuf/types/known/durationpb"
 	"google.golang.org/protobuf/types/known/emptypb"
 	"google.golang.org/protobuf/types/known/timestamppb"
+	"google.golang.org/protobuf/types/known/wrapperspb"
 )
 
 const (
@@ -911,7 +912,7 @@ func lastBatteryPercentage(dev *ttnpb.EndDevice) *ttnpb.LastBatteryPercentage {
 
 	return &ttnpb.LastBatteryPercentage{
 		FCnt:       dev.MacState.LastDevStatusFCntUp,
-		Value:      dev.BatteryPercentage,
+		Value:      wrapperspb.Float(dev.BatteryPercentage.Value * 100),
 		ReceivedAt: dev.LastDevStatusReceivedAt,
 	}
 }

diff --git a/pkg/ttnpb/messages.pb.go b/pkg/ttnpb/messages.pb.go
diff --git a/pkg/ttnpb/messages.pb.validate.go b/pkg/ttnpb/messages.pb.validate.go
diff --git a/sdk/js/generated/api.json b/sdk/js/generated/api.json
@@ -40305,7 +40305,7 @@
                 "validate.rules": [
                   {
                     "name": "float.lte",
-                    "value": 1
+                    "value": 100
                   },
                   {
                     "name": "float.gte",