Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of support access changes #7406

Merged
merged 40 commits into from
Nov 27, 2024
Merged

Conversation

nicholaspcr
Copy link
Contributor

@nicholaspcr nicholaspcr commented Nov 25, 2024

Summary

References https://github.com/TheThingsIndustries/lorawan-stack/issues/4330

Changes

  • Adds purge rights for application, organizations, Oauth clients, gateways and users.
  • Add list and create user rights.
  • Update registry tests to have a separate Permissions test function

Testing

Steps

For this PR in specific the only tests are the unit tests.

Regressions

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr added this to the v3.33.0 milestone Nov 25, 2024
@nicholaspcr nicholaspcr self-assigned this Nov 25, 2024
@nicholaspcr nicholaspcr force-pushed the backport/4330-support-access branch from cff5282 to 82939ec Compare November 25, 2024 22:04
@github-actions github-actions bot added c/identity server This is related to the Identity Server compat/db This could affect Database compatibility ui/web This is related to a web interface labels Nov 25, 2024
@nicholaspcr nicholaspcr force-pushed the backport/4330-support-access branch from 82939ec to f48342b Compare November 26, 2024 11:12
@nicholaspcr nicholaspcr marked this pull request as ready for review November 26, 2024 11:54
@nicholaspcr nicholaspcr requested review from a team as code owners November 26, 2024 11:54
@johanstokking
Copy link
Member

Great, let's wait for merge downstream just to be sure we don't run into diffs.

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like downstream is merged

@nicholaspcr nicholaspcr force-pushed the backport/4330-support-access branch from 9a5a792 to 6d1ebfd Compare November 27, 2024 11:40
@johanstokking johanstokking merged commit 93518e5 into v3.33 Nov 27, 2024
14 of 16 checks passed
@johanstokking johanstokking deleted the backport/4330-support-access branch November 27, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server compat/db This could affect Database compatibility ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants