Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gateway server event data change during marshaling #7430

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

vlasebian
Copy link
Contributor

@vlasebian vlasebian commented Dec 5, 2024

Summary

References support issue #1163.

Changes

  • Clone event data when registering evtGatewayConnectionStats
  • Add panic recover with logging in event data marshalling function

Testing

TODO

Steps
Results
Regressions

None.

Notes for Reviewers

I'm not really sure if this will give us more info than the debug stack that's already shown on panic recovery of the task.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@vlasebian vlasebian self-assigned this Dec 5, 2024
@github-actions github-actions bot added the c/gateway server This is related to the Gateway Server label Dec 5, 2024
@vlasebian vlasebian added this to the v3.33.1 milestone Dec 5, 2024
@vlasebian vlasebian marked this pull request as ready for review December 5, 2024 13:26
@vlasebian vlasebian requested review from a team as code owners December 5, 2024 13:26
@vlasebian vlasebian requested a review from KrishnaIyer December 5, 2024 13:26
@vlasebian vlasebian marked this pull request as draft December 5, 2024 13:30
@vlasebian vlasebian marked this pull request as ready for review December 5, 2024 13:48
@vlasebian vlasebian force-pushed the gs-event-data-update-while-marshaling branch from 7711dba to 9e374c3 Compare December 5, 2024 14:03
@github-actions github-actions bot added the ui/web This is related to a web interface label Dec 5, 2024
pkg/events/events.go Outdated Show resolved Hide resolved
pkg/events/events.go Show resolved Hide resolved
@vlasebian vlasebian force-pushed the gs-event-data-update-while-marshaling branch from 9e374c3 to 44dc815 Compare December 6, 2024 12:49
@vlasebian vlasebian merged commit 52748a4 into v3.33 Dec 6, 2024
14 of 15 checks passed
@vlasebian vlasebian deleted the gs-event-data-update-while-marshaling branch December 6, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway server This is related to the Gateway Server ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants