-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quick actions panel #7431
Open
ryaplots
wants to merge
10
commits into
v3.33
Choose a base branch
from
fix/quick-actions-panel
base: v3.33
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix quick actions panel #7431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryaplots
added
c/console
This is related to the Console
ui/web
This is related to a web interface
labels
Dec 5, 2024
ryaplots
requested review from
mjamescompton and
pierrephz
and removed request for
mjamescompton
December 9, 2024 12:49
ryaplots
force-pushed
the
fix/quick-actions-panel
branch
from
December 16, 2024 15:59
36edd97
to
67a1856
Compare
pierrephz
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2nd review here: https://www.figma.com/design/7pBLWK4tsjoAbyJq2viMAQ/console?node-id=6620-16595&t=yzyVp8eSJhYTp9zR-1
Again, feel free to dm me, especially for the icon group, we can do it over a call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #7348
Changes
Testing
Steps
Open console and see the panel in a different place and make sure all buttons work
Results
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.