-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check ADR bit in LinkADRAns
#7447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
c/network server
This is related to the Network Server
label
Dec 17, 2024
johanstokking
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References: #7376
According to the LoRaWAN spec 1.0.3 and 1.0.4 the Network Server should check the ADR bit in the
LinkADRAns
and based on that decide if the End device rejected the request or not.Changes
HandleLinkADRAns
to use the ADR bit too (if the MAC version is 1.0.3 or 1.0.4) when it checks theChannelMaskAck
,DataRateIndexAck
andTxPowerIndexAck
bitsTesting
Steps
LinkADRReq
command from network serverLinkADRAns
and theChannelMaskAck
bit should be on and theADR
bit should be off in the uplinkFCtrl
LinkADRReq
againResults
Regressions
...
Notes for Reviewers
...
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.