Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default page limit to 100 on AS and NS List RPCs #7499

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Feb 4, 2025

Summary

References: https://github.com/TheThingsIndustries/lorawan-stack/issues/4441

In v3.33.1 we introduced the possibility to enforce default pagination limit on AS and NS List RPCs but we didn't set the default value. Now in the v3.34 we are setting the default value to 100.

Changes

  • Set default page limit to 100 on AS and NS List RPCs

Testing

Steps
  • Create more than 100 MAC setting profiles
  • Call the List endpoint without pagination limit set -> it should return with only 100 MAC settings profile
Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi requested review from a team as code owners February 4, 2025 10:15
@halimi halimi requested a review from johanstokking February 4, 2025 10:15
@halimi halimi self-assigned this Feb 4, 2025
@halimi halimi added this to the v3.34.0 milestone Feb 4, 2025
@github-actions github-actions bot added c/network server This is related to the Network Server compat/config This could affect Configuration compatibility labels Feb 4, 2025
CHANGELOG.md Outdated Show resolved Hide resolved
@halimi halimi requested a review from KrishnaIyer February 4, 2025 12:26
@halimi halimi merged commit 82b7811 into v3.34 Feb 4, 2025
12 of 13 checks passed
@halimi halimi deleted the feature/set-default-page-limit branch February 4, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server compat/config This could affect Configuration compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants