-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
…c-draft. svn:r21072
svn:r21074
svn:r21078
svn:r21079
svn:r21080
the 'plus' approach should work for everybody. make it clearer which addresses to send to for your language. use "zh" rather than "zh_CN" in the examples. we need to make an alias that will let that work. svn:r21081
svn:r21083
svn:r21084
svn:r21085
svn:r21087
…es translated (0 fuzzy). svn:r21109
svn:r21110
svn:r21111
svn:r21112
svn:r21119
…s :-/) svn:r21132
svn:r21137
svn:r21151
svn:r21183
…build in a separate routine svn:r21185
…g strings for stats purposes (See #17588).
move get_bundle_info, get_file_sha256, valid_format to gettor/utils.py
Thanks @DonnchaC! Using releases instead of committing the files seems like a good option. I have checked other repos with releases and all seem to have the "Source Code" (zip and tar.gz) files that you mention. From what I understand, the changes to bundles2github add a new zip file for each of the bundles, in addition to Source Code, right? Having an updated README (or landing page) with the links would certainly be of help, and it could help to avoid people from downloading the useless "Source Code" files (I will open a new ticket to discuss that). I will also check if github3 module is available to use on getulum (or see if I can install it). Merging this changes will depend on that. |
@DonnchaC github3 is not available on getulum for installing it system-wide and I couldn't install it locally either (for the user in the server). However, the current script uses libsaas, which also have support for releases. What do you think of rewriting your changes to use libsaas? p.s.: there is also a Downloads resource, maybe we can avoid the "Source Code" thing with that? (I haven't tried it, I'm just thinking out loud). |
Sure! Let me check if I can port this to use the |
I've filled a ticket asking the The |
Unfortunately we can't get github3.py installed on getulum (the box where gettor runs). The system does not have github3 available for installing it via apt and pip is not available. When trying to install it locally it fails on uritemplate dependency. |
Just for the record, with the help of @DonnchaC I could finally install github3 on the gettor box. So, changes look good to me. Thanks! |
Host TBB bundles on Github Releases
This updates the
upload/bundles2github.py
script to host Tor Browser bundles on Github releases rather than committing the files into a massive git repo.The user experience could be improved by pushing as updated
README.md
for theTheTorProject/gettorbrowser
repo which links to the latest bundle in different languages. If this repo was spread and indexed in Google this would be a good censorship resistant way of getting Tor without even having to email GetTor.Ideas for how to improve the user experience are welcome. One current issue is that the releases page shows meaningless links to 'Source Code' archives. We should look to see if these links can be disabled.