Rewrite #12
Open
Rewrite #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 25, 2022 11:21
This ensures that the entire object is updated, and unnecessary fields are deleted.
jhaynie
pushed a commit
to jhaynie/synator
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add functionality for controlling which labels/annotations are copied, but ended up with something closer to a rewrite.
I'm just putting this out here, but obviously there may be too many differences (many incompatible) for this to be merged.
The one rather significant change I'll call attention to is the use of a label rather than annotation for triggering the controller. This is important for performance because labels can be queried (selected), while with annotations the controller has to download every configmap and secret in the cluster.