Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problematic error handling in todo app backend code #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MagentaManifold
Copy link

The response will never be sent if .send is not called on res, resulting in infinite waiting (or timeout).

The response will never be sent if `.send` is not called on `res`, resulting in infinite waiting (or timeout).
@MagentaManifold
Copy link
Author

I spent an hour debugging my own lab4 code because of this 😅

I haven't checked out example code for future lectures, but please fix them if this error is also in them.

And, please add tests to verify the behavior of 404 responses, if possible, so that this kind of bugs can be eradicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant