Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

[FC-38][DEC-517] Update node 18 #24

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[FC-38][DEC-517] Update node 18 #24

merged 1 commit into from
Feb 23, 2024

Conversation

hieucchu-eh
Copy link

@hieucchu-eh hieucchu-eh commented Feb 19, 2024 •
edited
Loading

  • Update CI to use node 18 (only sonarqube) + engines to Node 18.
  • yarn installation and all commands work as expected.

@hieucchu-eh hieucchu-eh marked this pull request as ready for review February 20, 2024 04:18
@phthhieu phthhieu closed this Feb 21, 2024
@phthhieu phthhieu reopened this Feb 21, 2024
@phthhieu
Copy link

@hieucchu-eh Likely gitleak blocks this PR, could you reach the platform team to support it? TIA

@hieucchu-eh
Copy link
Author

@hieucchu-eh Likely gitleak blocks this PR, could you reach the platform team to support it? TIA

Waiting
https://employmenthero.atlassian.net/browse/PLTS-4349?focusedCommentId=194830

@hieucchu-eh hieucchu-eh merged commit 32b94a0 into master Feb 23, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ttkien ttkien ttkien approved these changes

@phthhieu phthhieu phthhieu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hieucchu-eh @phthhieu @ttkien