Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixed broken link in location guidance #389

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

mrshll1001
Copy link
Contributor

This PR introduces a non-normative change to the docs and therefore doesn't have any versioning implications.

Changed link on the Location Guidance page from:

to

As per Planio #50521

The branch is building properly thanks to changes introduced in main:

@mrshll1001 mrshll1001 requested a review from KDuerden September 5, 2024 07:46
@@ -68,7 +68,7 @@ See our guidance on [converting postcodes into geocodes](converting-postcodes-in
### Recipient location codes
In cases when it isn’t possible or appropriate to publish postal codes, it is possible to publish recipient location in the form of Office for National Statistics (ONS) geocodes.

When 360Giving data includes recipient location codes at UK **Country**, **English Region**, **Local Authority**, **Ward** or **LSOA** level, these will work with the <a href="https://help.grantnav.threesixtygiving.org/en/latest/locations.html" target="_blank">location filtering functions</a> of GrantNav, 360Giving’s search engine for grants data.
When 360Giving data includes recipient location codes at UK **Country**, **English Region**, **Local Authority**, **Ward** or **LSOA** level, these will work with the <a href="https://help.grantnav.threesixtygiving.org/en/latest/#location-pages" target="_blank">location filtering functions</a> of GrantNav, 360Giving’s search engine for grants data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mrshll1001

The updated url isn't the best one to use, so apologies for extra step needed. Please can you amend to this instead:

https://help.grantnav.threesixtygiving.org/en/latest/locations/

Copy link
Contributor

@KDuerden KDuerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested a change to the update URL to avoid users needing to click an extra link to get to the info they need.

Once that is done I'm happy to review and approve again.

@neelima-j neelima-j self-assigned this Oct 17, 2024
@neelima-j neelima-j requested a review from KDuerden October 17, 2024 11:06
@neelima-j
Copy link
Contributor

I've applied the URL change.
My commit appears to have removed some spaces and tabs from the ends of lines. I've compared the rendered pages in this branch to the live version and there are no visual changes.

@neelima-j neelima-j merged commit f969121 into main Nov 1, 2024
2 checks passed
@neelima-j neelima-j deleted the bugfix-broken-link-in-location-guide branch November 1, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants