Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace slash with hyphen in archive name for scoped packages #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

o-farooq
Copy link

@o-farooq o-farooq commented Mar 8, 2016

When packaging a scoped package, following error is displayed because of the '/' in package name. scoped packages have naming convention @somescope/somepackagename . fixed by replacing '/' with '-'

Running "lambda_package:default" (lambda_package) task
Fatal error: ENOENT: no such file or directory, open 'C:\Users****\AppData\Local\Temp\1457437821029.6345@az\bit-api_1-0-0_2016-2-9-0-50-21.zip'

@Tim-B
Copy link
Owner

Tim-B commented Mar 20, 2016

Thanks for the pull request!

Would you mind adding some unit tests? Also, would this affect behaviour for existing users who might have hard-coded the output package name somewhere? Do you think it might be better to have an option to enable or disable it?

@joInMontreal
Copy link

Thanks for your fix ! It really helped me! can't wait to see that on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants