Skip to content

Commit

Permalink
Trace logging for ESThreadPoolExecutor#remove (elastic#108688)
Browse files Browse the repository at this point in the history
this is just to find out if we ever remove the tasks from the
threadPoolExecutor in order to make the Kibana(System) ThreadPool tests
reliable
  • Loading branch information
pgomulka authored May 15, 2024
1 parent 6922441 commit 7f1976d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@
* threads that wait on a phaser. This lets us verify that operations on system indices
* are being directed to other thread pools.</p>
*/
@TestLogging(reason = "investigate", value = "org.elasticsearch.kibana.KibanaThreadPoolIT:DEBUG")
@TestLogging(
reason = "investigate",
value = "org.elasticsearch.kibana.KibanaThreadPoolIT:DEBUG,org.elasticsearch.common.util.concurrent.EsThreadPoolExecutor:TRACE"
)
public class KibanaThreadPoolIT extends ESIntegTestCase {
private static final Logger logger = LogManager.getLogger(KibanaThreadPoolIT.class);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@ public final String toString() {
return b.toString();
}

@Override
public boolean remove(Runnable task) {
logger.trace(() -> "task is removed " + task);
return super.remove(task);
}

/**
* Append details about this thread pool to the specified {@link StringBuilder}. All details should be appended as key/value pairs in
* the form "%s = %s, "
Expand Down

0 comments on commit 7f1976d

Please sign in to comment.