Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul: VmRef #5

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Overhaul: VmRef #5

merged 5 commits into from
Nov 28, 2023

Conversation

Tinyblargon
Copy link
Owner

Work done:

  • Moved the VmRef class/struct into it's own file (this should not have been in client.go) 0df16e7.
  • Changed Client.CheckVmRef() to VmRef.Check() as it uses the client class but shouldn't be part of it 12e4f82.
  • Error for empty pointer to *VmRef is now a constant 53e6747.
  • Add nilCheck() to VmRef.Check() preventing possible panic d5c6bed.
  • Added unit test for VmRef.nilCheck() 8721be6.

@Tinyblargon Tinyblargon self-assigned this Nov 28, 2023
@Tinyblargon Tinyblargon merged commit 963bb8c into main Nov 28, 2023
1 check passed
@Tinyblargon Tinyblargon deleted the overhaul-VmRef branch November 28, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tinyblargon Tinyblargon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tinyblargon