BLAS scal and trsv benchmarks #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbaghdadi
requested changes
Mar 28, 2019
There was a problem hiding this comment.
Thanks Abdous. The code seems to be quite good.
Can you remove the files generated_scal.o.h generated_trsv.o.h from your commit? These files are generated automatically and therefore should not need to be stored on git.
Other than this, I think the commit is ready for merging.
|
@rbaghdadi Done. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here you can find benchmarks for two BLAS operations : scal and trsv.
SCAL implements multiplication of a scalar and a vector and TRSV solving triangular linear problems.
I have tried to do vectorization for the TRSV algorithm, but didn't managed to. I have posted a related issue here #197.
Thank you.