Skip to content

Commit

Permalink
t5520: do not use pull.rebase=preserve
Browse files Browse the repository at this point in the history
Even if those tests try to override that setting, let's not use it
because it is deprecated: let's use `merges` instead.

Signed-off-by: Johannes Schindelin <[email protected]>
Reviewed-by: Ævar Arnfjörð Bjarmason <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
dscho authored and gitster committed Sep 8, 2021
1 parent 225bc32 commit 6df8755
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions t/t5520-pull.sh
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ test_expect_success '--rebase=false create a new merge commit' '

test_expect_success '--rebase=true rebases and flattens keep-merge' '
git reset --hard before-preserve-rebase &&
test_config pull.rebase preserve &&
test_config pull.rebase merges &&
git pull --rebase=true . copy &&
test_cmp_rev HEAD^^ copy &&
echo file3 >expect &&
Expand All @@ -620,9 +620,9 @@ test_expect_success '--rebase=invalid fails' '
test_must_fail git pull --rebase=invalid . copy
'

test_expect_success '--rebase overrides pull.rebase=preserve and flattens keep-merge' '
test_expect_success '--rebase overrides pull.rebase=merges and flattens keep-merge' '
git reset --hard before-preserve-rebase &&
test_config pull.rebase preserve &&
test_config pull.rebase merges &&
git pull --rebase . copy &&
test_cmp_rev HEAD^^ copy &&
echo file3 >expect &&
Expand Down

0 comments on commit 6df8755

Please sign in to comment.