Skip to content

Commit

Permalink
git docs: add a category for file formats, protocols and interfaces
Browse files Browse the repository at this point in the history
Create a new "File formats, protocols and other developer interfaces"
section in the main "git help git" manual page and start moving the
documentation that now lives in "Documentation/technical/*.git" over
to it. This complements the newly added and adjacent "Repository,
command and file interfaces" section.

This makes the technical documentation more accessible and
discoverable. Before this we wouldn't install it by default, and had
no ability to build man page versions of them. The links to them from
our existing documentation link to the generated HTML version of these
docs.

So let's start moving those over, starting with just the
"bundle-format.txt" documentation added in 7378ec9 (doc: describe
Git bundle format, 2020-02-07). We'll now have a new
gitformat-bundle(5) man page. Subsequent commits will move more git
internal format documentation over.

Unfortunately the syntax of the current Documentation/technical/*.txt
is not the same (when it comes to section headings etc.) as our
Documentation/*.txt documentation, so change the relevant bits of
syntax as we're moving this over.

Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
avar authored and gitster committed Aug 4, 2022
1 parent d976c51 commit 844739b
Show file tree
Hide file tree
Showing 11 changed files with 94 additions and 13 deletions.
3 changes: 2 additions & 1 deletion Documentation/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ MAN1_TXT += gitweb.txt

# man5 / man7 guides (note: new guides should also be added to command-list.txt)
MAN5_TXT += gitattributes.txt
MAN5_TXT += gitformat-bundle.txt
MAN5_TXT += githooks.txt
MAN5_TXT += gitignore.txt
MAN5_TXT += gitmailmap.txt
Expand Down Expand Up @@ -95,7 +96,6 @@ TECH_DOCS += MyFirstObjectWalk
TECH_DOCS += SubmittingPatches
TECH_DOCS += ToolsForGit
TECH_DOCS += technical/bitmap-format
TECH_DOCS += technical/bundle-format
TECH_DOCS += technical/cruft-packs
TECH_DOCS += technical/hash-function-transition
TECH_DOCS += technical/http-protocol
Expand Down Expand Up @@ -290,6 +290,7 @@ cmds_txt = cmds-ancillaryinterrogators.txt \
cmds-synchingrepositories.txt \
cmds-synchelpers.txt \
cmds-guide.txt \
cmds-developerinterfaces.txt \
cmds-userinterfaces.txt \
cmds-purehelpers.txt \
cmds-foreignscminterface.txt
Expand Down
14 changes: 9 additions & 5 deletions Documentation/git-bundle.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,9 @@ using "thin packs", bundles created using exclusions are smaller in
size. That they're "thin" under the hood is merely noted here as a
curiosity, and as a reference to other documentation.

See link:technical/bundle-format.html[the `bundle-format`
documentation] for more details and the discussion of "thin pack" in
link:technical/pack-format.html[the pack format documentation] for
further details.
See linkgit:gitformat-bundle[5] for more details and the discussion of
"thin pack" in link:technical/pack-format.html[the pack format
documentation] for further details.

OPTIONS
-------
Expand All @@ -77,7 +76,7 @@ verify <file>::
commits exist and are fully linked in the current repository.
Then, 'git bundle' prints a list of missing commits, if any.
Finally, information about additional capabilities, such as "object
filter", is printed. See "Capabilities" in link:technical/bundle-format.html
filter", is printed. See "Capabilities" in linkgit:gitformat-bundle[5]
for more information. The exit code is zero for success, but will
be nonzero if the bundle file is invalid.

Expand Down Expand Up @@ -337,6 +336,11 @@ You can also see what references it offers:
$ git ls-remote mybundle
----------------

FILE FORMAT
-----------

See linkgit:gitformat-bundle[5].

GIT
---
Part of the linkgit:git[1] suite
5 changes: 5 additions & 0 deletions Documentation/git-help.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ SYNOPSIS
'git help' [-g|--guides]
'git help' [-c|--config]
'git help' [--user-interfaces]
'git help' [--developer-interfaces]

DESCRIPTION
-----------
Expand Down Expand Up @@ -83,6 +84,10 @@ user-interface conventions (e.g. linkgit:gitcli[7]), and
pseudo-configuration such as the file-based `.git/hooks/*` interface
described in linkgit:githooks[5].

--developer-interfaces::
Print list of file formats, protocols and other developer
interfaces documentation on the standard output.

-i::
--info::
Display manual page for the command in the 'info' format. The
Expand Down
9 changes: 9 additions & 0 deletions Documentation/git.txt
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,15 @@ linkgit:git-help[1] for more details on the critera.

include::cmds-userinterfaces.txt[]

File formats, protocols and other developer interfaces
------------------------------------------------------

This documentation discusses file formats, over-the-wire protocols and
other git developer interfaces. See `--developer-interfaces` in
linkgit:git-help[1].

include::cmds-developerinterfaces.txt[]

Configuration Mechanism
-----------------------

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,33 @@
= Git bundle v2 format
gitformat-bundle(5)
===================

The Git bundle format is a format that represents both refs and Git objects.
NAME
----
gitformat-bundle - The bundle file format


SYNOPSIS
--------
[verse]
*.bundle
*.bdl

DESCRIPTION
-----------

The Git bundle format is a format that represents both refs and Git
objects. A bundle is a header in a format similar to
linkgit:git-show-ref[1] followed by a pack in *.pack format.

== Format
The format is created and read by the linkgit:git-bundle[1] command,
and supported by e.g. linkgit:git-fetch[1] and linkgit:git-clone[1].


FORMAT
------

We will use ABNF notation to define the Git bundle format. See
protocol-common.txt for the details.
link:technical/protocol-common.html for the details.

A v2 bundle looks like this:

Expand Down Expand Up @@ -36,7 +58,9 @@ value = *(%01-09 / %0b-FF)
pack = ... ; packfile
----

== Semantics

SEMANTICS
---------

A Git bundle consists of several parts.

Expand All @@ -62,13 +86,15 @@ In the bundle format, there can be a comment following a prerequisite obj-id.
This is a comment and it has no specific meaning. The writer of the bundle MAY
put any string here. The reader of the bundle MUST ignore the comment.

=== Note on the shallow clone and a Git bundle
Note on the shallow clone and a Git bundle
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Note that the prerequisites does not represent a shallow-clone boundary. The
semantics of the prerequisites and the shallow-clone boundaries are different,
and the Git bundle v2 format cannot represent a shallow clone repository.

== Capabilities
CAPABILITIES
------------

Because there is no opportunity for negotiation, unknown capabilities cause 'git
bundle' to abort.
Expand All @@ -79,3 +105,7 @@ bundle' to abort.
* `filter` specifies an object filter as in the `--filter` option in
linkgit:git-rev-list[1]. The resulting pack-file must be marked as a
`.promisor` pack-file after it is unbundled.

GIT
---
Part of the linkgit:git[1] suite
3 changes: 3 additions & 0 deletions Documentation/lint-man-section-order.perl
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
'SEE ALSO' => {
order => $order++,
},
'FILE FORMAT' => {
order => $order++,
},
'GIT' => {
required => 1,
order => $order++,
Expand Down
9 changes: 9 additions & 0 deletions builtin/help.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ static enum help_action {
HELP_ACTION_GUIDES,
HELP_ACTION_CONFIG,
HELP_ACTION_USER_INTERFACES,
HELP_ACTION_DEVELOPER_INTERFACES,
HELP_ACTION_CONFIG_FOR_COMPLETION,
HELP_ACTION_CONFIG_SECTIONS_FOR_COMPLETION,
} cmd_mode;
Expand Down Expand Up @@ -73,6 +74,9 @@ static struct option builtin_help_options[] = {
OPT_CMDMODE(0, "user-interfaces", &cmd_mode,
N_("print list of user-facing repository, command and file interfaces"),
HELP_ACTION_USER_INTERFACES),
OPT_CMDMODE(0, "developer-interfaces", &cmd_mode,
N_("print list of file formats, protocols and other developer interfaces"),
HELP_ACTION_DEVELOPER_INTERFACES),
OPT_CMDMODE('c', "config", &cmd_mode, N_("print all configuration variable names"),
HELP_ACTION_CONFIG),
OPT_CMDMODE_F(0, "config-for-completion", &cmd_mode, "",
Expand All @@ -89,6 +93,7 @@ static const char * const builtin_help_usage[] = {
"git help [-g|--guides]",
"git help [-c|--config]",
"git help [--user-interfaces]",
"git help [--developer-interfaces]",
NULL
};

Expand Down Expand Up @@ -663,6 +668,10 @@ int cmd_help(int argc, const char **argv, const char *prefix)
opt_mode_usage(argc, "--user-interfaces", help_format);
list_user_interfaces_help();
return 0;
case HELP_ACTION_DEVELOPER_INTERFACES:
opt_mode_usage(argc, "--developer-interfaces", help_format);
list_developer_interfaces_help();
return 0;
case HELP_ACTION_CONFIG_SECTIONS_FOR_COMPLETION:
opt_mode_usage(argc, "--config-sections-for-completion",
help_format);
Expand Down
5 changes: 5 additions & 0 deletions command-list.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@
# sections 5 and 7. These entries can only have the "userinterfaces"
# attribute and nothing else.
#
# Git's file formats and protocols, such as documentation for the
# *.bundle format lives in man section 5. These entries can only have
# the "developerinterfaces" attribute and nothing else.
#
### command list (do not change this line)
# command name category [category] [category]
git-add mainporcelain worktree
Expand Down Expand Up @@ -205,6 +209,7 @@ gitcvs-migration guide
gitdiffcore guide
giteveryday guide
gitfaq guide
gitformat-bundle developerinterfaces
gitglossary guide
githooks userinterfaces
gitignore userinterfaces
Expand Down
12 changes: 12 additions & 0 deletions help.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ static struct category_description main_categories[] = {
{ CAT_synchingrepositories, N_("Low-level Commands / Syncing Repositories") },
{ CAT_purehelpers, N_("Low-level Commands / Internal Helpers") },
{ CAT_userinterfaces, N_("User-facing repository, command and file interfaces") },
{ CAT_developerinterfaces, N_("Developer-facing file file formats, protocols and interfaces") },
{ 0, NULL }
};

Expand All @@ -50,6 +51,7 @@ static const char *drop_prefix(const char *name, uint32_t category)
switch (category) {
case CAT_guide:
case CAT_userinterfaces:
case CAT_developerinterfaces:
prefix = "git";
break;
default:
Expand Down Expand Up @@ -445,6 +447,16 @@ void list_user_interfaces_help(void)
putchar('\n');
}

void list_developer_interfaces_help(void)
{
struct category_description catdesc[] = {
{ CAT_developerinterfaces, N_("File formats, protocols and other developer interfaces:") },
{ 0, NULL }
};
print_cmd_by_category(catdesc, NULL);
putchar('\n');
}

static int get_alias(const char *var, const char *value, void *data)
{
struct string_list *list = data;
Expand Down
1 change: 1 addition & 0 deletions help.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ void list_common_cmds_help(void);
void list_all_cmds_help(int show_external_commands, int show_aliases);
void list_guides_help(void);
void list_user_interfaces_help(void);
void list_developer_interfaces_help(void);

void list_all_main_cmds(struct string_list *list);
void list_all_other_cmds(struct string_list *list);
Expand Down
2 changes: 2 additions & 0 deletions t/t0012-help.sh
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ test_expect_success "'git help -a' section spacing" '
Low-level Commands / Internal Helpers
User-facing repository, command and file interfaces
Developer-facing file file formats, protocols and interfaces
EOF
test_cmp expect actual
'
Expand Down

0 comments on commit 844739b

Please sign in to comment.