Skip to content

Commit

Permalink
ci: fix check for Ubuntu 20.04
Browse files Browse the repository at this point in the history
In 5ca0c45 (ci: fix Python dependency on Ubuntu 24.04, 2024-05-06),
we made the use of Python 2 conditional on whether or not the CI job
runs Ubuntu 20.04. There was a brown-paper-bag-style bug though, where
the condition forgot to invoke the `test` builtin. The result of it is
that the check always fails, and thus all of our jobs run with Python 3
by accident.

Fix this.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pks-t authored and gitster committed Jun 6, 2024
1 parent 5ca0c45 commit df65133
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ci/lib.sh
Original file line number Diff line number Diff line change
@@ -328,7 +328,7 @@ ubuntu-*)
# Python 2 is end of life, and Ubuntu 23.04 and newer don't actually
# have it anymore. We thus only test with Python 2 on older LTS
# releases.
if "$distro" = "ubuntu-20.04"
if test "$distro" = "ubuntu-20.04"
then
PYTHON_PACKAGE=python2
else

0 comments on commit df65133

Please sign in to comment.