Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add a fully static build with A/V support. #258

Closed
wants to merge 1 commit into from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 30, 2023

This change is Reviewable

@iphydf iphydf added this to the 0.13.1 milestone Dec 30, 2023
@iphydf iphydf requested a review from a team as a code owner December 30, 2023 19:08
@iphydf iphydf force-pushed the docker-static branch 2 times, most recently from 2be25dc to b288098 Compare December 30, 2023 19:16
@nurupo
Copy link
Member

nurupo commented Dec 30, 2023

Does the a/v and x11 integration actually work through a Docker image? What arguments you pass when running the container to make them work?

When I was making the static tarball (not a Docker container) build of toxic I had to disable a/v for some reason. I think OpenAL-Soft was detecting which audio libraries I have at build-time, enabling only the audio backends for those libraries (well, afterall it can't built other backends with missing headers and library symbols), and then also hardcoding paths to their so-names to dlopen() them at run-time, or something along these lines? Don't remember exactly. Well, whatever it was, the end result was that the resulting fully static binary wasn't portable across different distros.

@nurupo
Copy link
Member

nurupo commented Dec 30, 2023

Hm, I see ALSOFT_DLOPEN=OFF, I wonder if that all it takes to get it to work. Would need to play with OpenAL-Soft again.

@iphydf
Copy link
Member Author

iphydf commented Dec 31, 2023

I don't know if it works in docker. Probably you can volume-mount enough X11 stuff into it to make it work. I only tested that it works in the terminal and that it connects. I don't have a working X server to test with at the moment.

@iphydf iphydf force-pushed the docker-static branch 5 times, most recently from aff6242 to 055e040 Compare December 31, 2023 17:43
@iphydf iphydf modified the milestones: 0.13.1, 0.13.2 Jan 6, 2024
@iphydf iphydf modified the milestones: 0.14.0, 0.14.1 Feb 1, 2024
@iphydf iphydf removed this from the 0.14.1 milestone Feb 11, 2024
@iphydf iphydf closed this Feb 12, 2024
@iphydf
Copy link
Member Author

iphydf commented Feb 12, 2024

Closing for inactivity and pushback.

@nurupo
Copy link
Member

nurupo commented Feb 14, 2024

Eh? What pushback? If you have interpreted my comments as a pushback then you are very mistaken, this PR is welcome by me. I have only expressed my surprise at you getting this to work and me not knowing of the ALSOFT_DLOPEN=OFF option before, wanting to play around with that option in my spare time (as it might enable us to have av enabled in the minimal static toxic build, which has nothing to do with the PR, i.e. you are not blocked by me playing around with that option). It would be great if someone who is familiar with toxic and able to test the a/v features could review this PR.

@JFreegman
Copy link
Member

It would be great if someone who is familiar with toxic and able to test the a/v features could review this PR.

I tested it and the A/V didn't work. I'm not against it though, I think it'd be great to get it working and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants