Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing and linting #91

Merged
merged 5 commits into from
Dec 16, 2023
Merged

Typing and linting #91

merged 5 commits into from
Dec 16, 2023

Conversation

dustalov
Copy link
Collaborator

Another round of typing fixes.

Checklist

  • I have read the CONTRIBUTING document
  • I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a4f7) 93.01% compared to head (f0470bf) 92.80%.

Files Patch % Lines
crowdkit/aggregation/classification/glad.py 88.23% 4 Missing ⚠️
crowdkit/aggregation/classification/dawid_skene.py 86.36% 3 Missing ⚠️
crowdkit/aggregation/classification/kos.py 50.00% 3 Missing ⚠️
crowdkit/aggregation/classification/mace.py 75.00% 3 Missing ⚠️
crowdkit/aggregation/texts/text_hrrasa.py 50.00% 2 Missing ⚠️
crowdkit/aggregation/texts/text_rasa.py 66.66% 2 Missing ⚠️
crowdkit/learning/text_summarization.py 71.42% 2 Missing ⚠️
crowdkit/aggregation/embeddings/hrrasa.py 85.71% 1 Missing ⚠️
.../aggregation/image_segmentation/segmentation_em.py 88.88% 1 Missing ⚠️
crowdkit/metrics/data/_classification.py 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   93.01%   92.80%   -0.22%     
==========================================
  Files          47       47              
  Lines        2019     2070      +51     
==========================================
+ Hits         1878     1921      +43     
- Misses        141      149       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dustalov
Copy link
Collaborator Author

@varfolomeii @alexdrydew @pilot7747 @aliskin @DrhF I'm going to merge this as it passes the tests, but the Markdown generator does not seem to be working. The problem seems to be in the parameterized type definition, pd.Series[Any]: https://github.com/Toloka/crowd-kit/actions/runs/7233283348/job/19708369772. Could you please fix the upstream?

@dustalov dustalov merged commit 3589b70 into main Dec 16, 2023
0 of 10 checks passed
@dustalov dustalov deleted the typing branch December 16, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants