-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Event Trigger for Infinite Fuel Toggle #270
base: development
Are you sure you want to change the base?
Conversation
I'm pretty sure you also need to register the event, so people can just AddEventHandler to it in their script. |
It doesn't require registering unless it's going across the Net, which it isn't - it is a client side only event |
I have a suggestion for an additional change, that'd make this more useful, whenever the resource loads and it sets the original value form the saved preferences, it should trigger the event once so your other resource has a chance of knowing what the status is once a player joins and doesn't toggle it manually. Or exposing an export function that gets the current value. |
Other than that it's a useful feature |
b6f3ea2
to
7504416
Compare
Could you rebase your changes based on the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments need to be resolved
Allows custom fuel resources to watch for infinite fuel in vMenu
Co-authored-by: Christopher M. <[email protected]>
The current development version has no userDefault for this setting, so it may not be necessary to do an initial check! Also, I rebased, but I am not a Git-master... so I am unsure why it is now 3 commits despite only the 1 change. |
Allows custom fuel resources to watch for infinite fuel in vMenu within other client-sided scripts.
Event name: "vMenu:InfiniteFuelToggled"
Passes one arg, the boolean representing whether the box is checked or not