Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
setuptools
,pip
andcythonize
to build and install the python wrapper. A newpyproject.toml
file is added insrc/Python
directory.Although it builds I still have troubles in testing after a local build as in #178
Notice that this PR simplifies the setup file and adds a second
Extension
in thesetup
command with the CMake variablesSETUP_GPU_WRAPPERS
andGPU_EXTRA_LIBRARIES
.This is built with the
cythonize
commandhttps://github.com/vais-ral/CCPi-Regularisation-Toolkit/blob/e229a7219797938e200174b8262a861ee766fb3f/src/Python/setup-regularisers.py.in#L57-L77