fix imports #1736
Merged
fix imports #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- downgrades severity of #1599
casperdcl
added
bug
RasmiaKulan
approved these changes
Feb 29, 2024
paskino
reviewed
Feb 29, 2024
| if backend == 'tigre': | ||
| raise ImportError("Cannot import the {} plugin module. Please install TIGRE or select a different backend".format(self.backend)) | ||
| raise ImportError(f"Please install `conda install tigre` or select a different backend") from exc |
There was a problem hiding this comment.
I am not sure that is the actual message we want to show. I'd be more generic as earlier and say, please install TIGRE, or ASTRA (below) without saying use conda.
This was referenced Mar 12, 2024
casperdcl
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
warnrather thanraiseonipywidgets>=8diff sans whitespace (PS see also #1734)
Testing you performed
Related issues/links
Checklist
I have added docstrings in line with the guidance in the developer guideI have updated the relevant documentationI have implemented unit tests that cover any new or modified functionalityContribution Notes
Please read and adhere to the developer guide and local patterns and conventions.