Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QCILViewerWidget add enableSliderWidget argument #386

Merged
merged 9 commits into from
May 14, 2024
Merged

Conversation

DanicaSTFC
Copy link
Collaborator

@DanicaSTFC DanicaSTFC commented May 1, 2024

Describe your changes

Describe any testing you have performed

Consider adding example code to examples

Standalone app:
I pip installed and tested with numpy magma data. Moved the slider in the 2D viewer and 3D viewer and spanned z with the mouse
I then set the enableSliderWidget to False and checked it did not appear int the viewer
I ran all the unit tests.

Link relevant issues

closes #384

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the CIL developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'waiting for review'

Contribution Notes

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CILViewer (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Qt contributions should follow Qt naming conventions i.e. camelCase method names.

VTK contributions should follow VTK naming conventions i.e. PascalCase method names.

@DanicaSTFC DanicaSTFC added this to the Version 24.0.0 milestone May 1, 2024
@DanicaSTFC DanicaSTFC self-assigned this May 1, 2024
@paskino paskino changed the title hide slider argument QCILViewerWidget enableSliderWidget argument May 9, 2024
@paskino paskino changed the title QCILViewerWidget enableSliderWidget argument QCILViewerWidget add enableSliderWidget argument May 9, 2024
@DanicaSTFC DanicaSTFC merged commit ae4a6e1 into master May 14, 2024
3 checks passed
@DanicaSTFC DanicaSTFC deleted the hide-slider branch May 14, 2024 11:07
@DanicaSTFC DanicaSTFC mentioned this pull request May 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

hide option for slider
2 participants