Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit axis labels #389

Merged
merged 15 commits into from
May 14, 2024
Merged

Edit axis labels #389

merged 15 commits into from
May 14, 2024

Conversation

DanicaSTFC
Copy link
Collaborator

@DanicaSTFC DanicaSTFC commented May 1, 2024

Describe your changes

  • Added method to edit labels of the axes in the viewer base class
  • Edited the key press event so that x y z are hidden on the 2D view when the orientation is changed
  • Added unit test for method edit the labels

Note: this PR does NOT add unit test for the interactor (changes in Wrappers/Python/ccpi/viewer/CILViewer2D.py). The x, y, z pressing and label editing should be added in a new PR.

Describe any testing you have performed

Consider adding example code to examples

Link relevant issues

Partially closes #122. Long text in the labels would still be not formatted well. Opened #398

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the CIL developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'waiting for review'

Contribution Notes

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CILViewer (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Qt contributions should follow Qt naming conventions i.e. camelCase method names.

VTK contributions should follow VTK naming conventions i.e. PascalCase method names.

@DanicaSTFC DanicaSTFC self-assigned this May 1, 2024
@DanicaSTFC DanicaSTFC linked an issue May 1, 2024 that may be closed by this pull request
@DanicaSTFC DanicaSTFC added this to the Version 24.0.0 milestone May 1, 2024
@DanicaSTFC DanicaSTFC merged commit 43c7d3b into master May 14, 2024
3 checks passed
@DanicaSTFC DanicaSTFC deleted the axis_labels branch May 14, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add option to set axis labels to vertical, horizontal and angle
3 participants