Deprecate Script #49
Merged
Deprecate Script #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pulled config parsing code out into its own function. - Starting warning the user that 'script' is deprecated and they should start using 'build'
Removed '-race' from the snag yaml as it causes tests to take quite a while. Having travis do the heavy lifting instead of doing it locally
| // if script has something, tell the user it's deprecated | ||
| // and set whatever its contents are to build | ||
| if len(c.Script) != 0 { | ||
| fmt.Println("The use of 'script' in the yaml file has been deprecated and will be removed in the future.") |
There was a problem hiding this comment.
What about adding a deprecation to the config so that the builder displays the message on every cleanup? That way we don't have to sleep at all?
There was a problem hiding this comment.
I like that better. That way they always see it and get reminded that we're going to pull the plug.
I see some sort of deprecation message on the config struct which we build while parsing the config. The builder would then check to see if it is set and then output it. What do you think?
zabawaba99
force-pushed
the
deprecate-script
branch
from
1ffe96b to
9181f5a
Compare
| f, err := os.Create(".snag.yml") | ||
| require.NoError(t, err, "could not create snag.yml") | ||
|
|
||
| _, err = f.WriteString(content) |
There was a problem hiding this comment.
Don't we have to close the file after writing the string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR deprecates the
scripttag on the.snag.ymlas per conversations on #48 . Also added some tests on the parsing side of things.