Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track playback for anonymous sessions #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adammw
Copy link
Collaborator

@adammw adammw commented Jan 9, 2014

Uses the Facebook account login flow to get track playback to work in anonymous sessions. See my comment on #58 for more details.

Also adds Track and Time Cap error codes, when the (anonymous) user has used up all the free tracks they can play without signing in.

While testing, I also noticed that anonymous sessions themselves are also ratelimited and the auth endpoint will return an error if your IP address tries to get too many sessions in a small window of time.

Currently the auth endpoint returns a 500 error when requesting an anonymous session the first time, so there's extra logic to do a retry, as it usually works afterwards. Superagent doesn't seem to save the cookies returned when the status code is 500, otherwise the second auth request would not be required as the landing page will have the credentials needed. Not sure how to fix that, but it still works anyway as the auth response sets the already_authenticated error and gives us the credentials we need anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant