Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify: added support for published and unpublished rootlist types, added addTrack, added createPlaylist, add addToRootList #85

Closed
wants to merge 1 commit into from

Conversation

niftylettuce
Copy link

Per #24, I've refactored to master branch and tested.

For some reason the playlisturi returned is not valid, e.g. when you do createPlaylist('someuser', 'some playlist title', function(err, uri) { the uri returned looks like hm://playlist/user/someuser instead of hm://playlist/user/someuser/1234567. I can't figure out why it's not adding to root list... perhaps it's the addRootList function?

Hopefully one of you guys can help, this is troublesome for a newbie on this project.

I've tried to reference https://github.com/Hexxeh/spotify-websocket-api/blob/master/spotify_web/spotify.py#L583-L608 and the OP commits of #24, but I still can't resolve.

One thing I saw was that proto/mercury.proto spec has changed per the latest .xml file and you can see the diff I commented out in proto/mercury.proto per this commit/PR. Specifically MercuryRequest has changed per https://github.com/Hexxeh/spotify-websocket-api/blob/master/spotify_web/proto/mercury.proto#L8-L13 and I'm wondering if this might have something to do with it?

Let me know, thanks! /cc @TooTallNate @adammw

…added addTrack, added createPlaylist, add addToRootList
@niftylettuce
Copy link
Author

$50-100+ bug bounty awarded to first person to find the solution, paid via PayPal or Gittip.

@clickbait
Copy link

@niftylettuce your code for addTrack does not work; even after uncommenting the definition and changing the ID for body in proto/mercury.pronto

the response from the request is essentially the request with a bunch of nonsense:

Hhm://playlist/user/username/playlist/5ppX2lZ9YIQzQXhstyyUjY?syncpublished=1� ª�2œ�
�Allow�’�ADD, CHANGES, DIFF, GET, GETAT, HEAD, HEADS, HISTORY, MERGE, MODIFY, OBLITERATE, OPTIONS, REMOVE, RESET, REVERT, SCAN, SCANPL3, SQUASH, SUB, UNSUB

With no songs actually being added to the playlist.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants