Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add:framework-zap #42

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

add:framework-zap #42

wants to merge 10 commits into from
+1,274 −0

Conversation

Sacramento-20
Copy link
Contributor

Pull request created, all basic information about the program's flow can be found in the README.

@Sacramento-20 Sacramento-20 requested a review from cunha September 5, 2024 17:42
cunha
cunha requested changes Sep 7, 2024
View reviewed changes
Copy link
Member

@cunha cunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments inline on suggestions to improve. The most significant one is the handling of the volume for exchanging inputs and outputs with the container, which will significantly simplify usage.

@Sacramento-20 Sacramento-20 requested a review from cunha December 23, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cunha cunha Awaiting requested review from cunha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sacramento-20 @cunha